8333824: Unused ClassValue in VarHandles #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
satyenme
changed the title
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Clean backport. Existing code is unused, so can safely be removed. Tested with tier1, tier2, and GHA tests. Risk is low. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8333824: Unused ClassValue in VarHandles. Removes completely unused code. Likely a leftover.. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch should be clean.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/193/head:pull/193$ git checkout pull/193Update a local copy of the PR:
$ git checkout pull/193$ git pull https://git.openjdk.org/jdk23u.git pull/193/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 193View PR using the GUI difftool:
$ git pr show -t 193Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/193.diff
Webrev
Link to Webrev Comment